jwk: Fix memory mamager of JWK deletion #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shota Sawada <xiootas@gmail.com>
|
Could you please add a test to the manager test suite to make sure that this won't break in a regression later on? Thank you! |
Signed-off-by: Shota Sawada <xiootas@gmail.com>
Signed-off-by: Shota Sawada <xiootas@gmail.com>
sawadashota
commented
Jun 18, 2019
| @@ -5,6 +5,8 @@ tools: | |||
| npm i | |||
| go get github.com/go-bindata/go-bindata/go-bindata | |||
| go install github.com/go-bindata/go-bindata/go-bindata | |||
| go get github.com/ory/go-acc | |||
| go install github.com/ory/go-acc | |||
There was a problem hiding this comment.
Added go-acc install command because make test requires.
|
Awesome, thank you! |
10 tasks
10 tasks
This was referenced Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
This PR will close #1473
Checklist
vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.