Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace in composer.json (again?) #1480

Closed
wants to merge 1 commit into from
Closed

Fix namespace in composer.json (again?) #1480

wants to merge 1 commit into from

Conversation

DASPRiD
Copy link
Contributor

@DASPRiD DASPRiD commented Jun 23, 2019

PR #1468 changed the namespace within the PHP files from Hydra\SDK to HydraSDK, but it did not update the autoload section in the composer.json file.

This seems to happen quite often recently, I wonder if there should be a test in place to avoid having a mismatch there ever.

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2019

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented Jun 23, 2019

It seems like that particular PR did not run make sdk, causing the composer.json file to not be updated. Running that command make sdk would be the right course of action for this PR imo.

@goknsh goknsh mentioned this pull request Aug 3, 2019
aeneasr added a commit that referenced this pull request Aug 19, 2019
aeneasr added a commit that referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants