Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create doc.go #1510

Closed
wants to merge 5 commits into from
Closed

Create doc.go #1510

wants to merge 5 commits into from

Conversation

haf
Copy link

@haf haf commented Aug 5, 2019

Like this?

Related issue

Proposed changes

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

metrics/prometheus/doc.go Outdated Show resolved Hide resolved
Co-Authored-By: hackerman <3372410+aeneasr@users.noreply.github.com>
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change :)

metrics/prometheus/doc.go Outdated Show resolved Hide resolved
Co-Authored-By: hackerman <3372410+aeneasr@users.noreply.github.com>
@aeneasr
Copy link
Member

aeneasr commented Aug 6, 2019

The linter fails: https://circleci.com/gh/ory/hydra/8914?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

If you don't have this project checked out locally or do not have go installed locally, you can format the file on the go playground by pasting the contents of the file there and hitting the "format" button at the top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants