Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: enrich oauth2_token_response and params #1551

Merged
merged 1 commit into from
Sep 4, 2019
Merged

SDK: enrich oauth2_token_response and params #1551

merged 1 commit into from
Sep 4, 2019

Conversation

tyaps
Copy link
Contributor

@tyaps tyaps commented Sep 2, 2019

Add IdToken and Scope to oauth2_token_response.
These fields are presented in response and should be parsed.

Add RefreshToken field to oauth2_token_params.
With RefreshToken field we will be able to refresh Access token
by providing Refresh token.

Relates #1509
Relates #1533

Related issue

Proposed changes

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2019

CLA assistant check
All committers have signed the CLA.

Add IdToken and Scope to oauth2_token_response.
These fields are presented in response and should be parsed.

Add RefreshToken field to oauth2_token_params.
With RefreshToken field we will be able to refresh Access token
by providing Refresh token.

Relates #1509
Relates #1533
@aeneasr
Copy link
Member

aeneasr commented Sep 4, 2019

Thank you!

@aeneasr aeneasr merged commit 55873d2 into ory:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants