Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop: Makes init task in makefile and corrects readme #1555

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

solodynamo
Copy link
Contributor

Related issue

#1507

Proposed changes

  • Create the task and correct readme.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

Makefile Outdated

.PHONY: init
init:
go get github.com/ory/go-acc
Copy link
Member

@aeneasr aeneasr Sep 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
go get github.com/ory/go-acc
GO111MODULE=on go get .
GO111MODULE=on go install github.com/ory/go-acc

@solodynamo
Copy link
Contributor Author

@aeneasr pls review.

@aeneasr
Copy link
Member

aeneasr commented Sep 16, 2019

Hi! Thank you for your contribution - just catching up to everything after a vacation :)

@aeneasr aeneasr merged commit f834907 into ory:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants