Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add client metadata #1602

Merged
merged 5 commits into from
Oct 18, 2019
Merged

Conversation

pike1212
Copy link
Contributor

Related issue

#1594

Proposed changes

Adds metadata field to oauth client

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2019

CLA assistant check
All committers have signed the CLA.

@pike1212
Copy link
Contributor Author

make test works for me locally, I did run make sdk and commit those changes, but not sure why these tests are failing

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This already looks really good. Tests fail because you added another CREATE TABLE test to cockroachdb, but an alter table is required - see my comments on the code. :)

client/client.go Outdated Show resolved Hide resolved
@@ -32,6 +32,7 @@ CREATE TABLE IF NOT EXISTS hydra_client (
post_logout_redirect_uris TEXT NOT NULL DEFAULT '',
backchannel_logout_uri TEXT NOT NULL DEFAULT '',
backchannel_logout_session_required BOOL NOT NULL DEFAULT FALSE,
metadata TEXT NOT NULL DEFAULT '{}',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires an ALTER statement, not another CREATE TABLE as it won't have any effect

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little unsure what needs done here, I added the 13.sql back and added a 14.sql with an alter statement, but I think the tests are still failing

client/migrations/sql/postgres/14.sql Outdated Show resolved Hide resolved
client/x_manager_sql_migrations_test.go Outdated Show resolved Hide resolved
client/x_manager_sql_migrations_test.go Outdated Show resolved Hide resolved
client/manager_sql.go Outdated Show resolved Hide resolved
client/manager_sql.go Outdated Show resolved Hide resolved
client/manager_sql.go Outdated Show resolved Hide resolved
@aeneasr
Copy link
Member

aeneasr commented Oct 16, 2019

Please run make sqlbin, then tests should pass.

@aeneasr
Copy link
Member

aeneasr commented Oct 18, 2019

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants