-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add client metadata #1602
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This already looks really good. Tests fail because you added another CREATE TABLE
test to cockroachdb, but an alter table
is required - see my comments on the code. :)
@@ -32,6 +32,7 @@ CREATE TABLE IF NOT EXISTS hydra_client ( | |||
post_logout_redirect_uris TEXT NOT NULL DEFAULT '', | |||
backchannel_logout_uri TEXT NOT NULL DEFAULT '', | |||
backchannel_logout_session_required BOOL NOT NULL DEFAULT FALSE, | |||
metadata TEXT NOT NULL DEFAULT '{}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires an ALTER
statement, not another CREATE TABLE
as it won't have any effect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little unsure what needs done here, I added the 13.sql back and added a 14.sql with an alter statement, but I think the tests are still failing
Please run |
Thank you for your contribution! |
Related issue
#1594
Proposed changes
Adds metadata field to oauth client
Checklist
vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
Further comments