docs: gitlab hydra integration #2007 #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Aug 24, 2020
docs/docs/guides/gitlab.mdx
Outdated
| ] | ||
| ``` | ||
|
|
||
| After you did these changes, restart the container: |
There was a problem hiding this comment.
NOTE TO SELF: Reviewed until here
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
|
I'm so happy to see that you've written the document quickly. I plan to build an internal SSO with Hydra, and I'll try to integrate it into gitlab, rancher, or others. Thank you for your excellent product. It's meaningful |
Csirme
reviewed
Aug 25, 2020
aeneasr
reviewed
Aug 25, 2020
aeneasr
reviewed
Aug 27, 2020
|
I've changed the whole guide to a "quick-up-and-running+troubleshooting" style, rather than a "failfast-and-fix-step-by-step" style. Another review triggered! |
aeneasr
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#2007 @aeneasr`
Proposed changes
Documenting the integration with gitlab. We're not directly using OpenID-connect in this guide but the reasons are mentioned in the appendix of gitlab.mdx.
I have not added this document to any version yet.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.