Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jwt-go and resolve warden regression issue #232

Merged
merged 3 commits into from
Aug 24, 2016
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Aug 23, 2016

No description provided.

Alexander Widerberg and others added 2 commits August 23, 2016 15:33
@aeneasr aeneasr added bug Something is not working. feat New feature or request. labels Aug 23, 2016
@aeneasr aeneasr added this to the 0.5.0 milestone Aug 23, 2016
@aeneasr aeneasr self-assigned this Aug 23, 2016
@aeneasr
Copy link
Member Author

aeneasr commented Aug 23, 2016

This PR should not break the database. Although the Signature of JWT Containers changed, they are not being saved to the database in Hydra. Plus, the float64 change won't matter to json anyways.

That's why this is tagged as 0.4.2

@leetal let me know if you disagree

@aeneasr aeneasr modified the milestones: 0.4.2, 0.5.0 Aug 23, 2016
@leetal
Copy link
Contributor

leetal commented Aug 23, 2016

Seems good to me!
Will have to fix a new version of fosite as well. Time for a 0.2.5? :)

@aeneasr
Copy link
Member Author

aeneasr commented Aug 23, 2016

I released fosite as 0.3.0 because it's still a possible bc break. :)

@leetal
Copy link
Contributor

leetal commented Aug 23, 2016 via email

@aeneasr aeneasr merged commit 1059b88 into master Aug 24, 2016
@aeneasr aeneasr deleted the fix-warden branch August 24, 2016 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working. feat New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants