Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: guide for merging system.secrets #2448

Merged
merged 6 commits into from
Apr 9, 2021
Merged

docs: guide for merging system.secrets #2448

merged 6 commits into from
Apr 9, 2021

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Apr 7, 2021

Related issue

#2445

As before, all credit goes to @bnm12.

Proposed changes

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

Comment on lines 51 to 53
We also delete the last line of the dump, since it sets the value of the primary
key sequence to the number of the donor database. So we need to delete this
line.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's any way of putting emphasis on this that would be good, it's very important.
This whole manual edits section is very important, but the first part will most likely just fail importing and not cause any harm if not done correctly, and can be recovered with a correct import afterwards (with a few harmless duplicate key errors). Where as if you forget to remove this line it will reset the sequence of hydra_clients.pk to whatever was in the source DB potentially breaking client creation going forwards until the sequence gets back in sync

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the input!
I put in some warnings, to make clear that this can potentially break client creation if you mess it up.

@aeneasr aeneasr merged commit 5466d4e into ory:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants