Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix grammar issues and typos #2830

Merged
merged 2 commits into from
Nov 9, 2021
Merged

docs: fix grammar issues and typos #2830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e5da55
autogen(openapi): Regenerate swagger spec and internal client
aeneasr Oct 28, 2021
566c3d9
Merge branch 'ory:master' into main
wanderer163 Nov 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/docs/concepts/before-oauth2.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ mobile app. And that's great, because the browser takes care of:

- Bound to one top-level-domain only;
- Anti-XSS with `httpOnly`
- TLS enforcment with `secure`;
- TLS enforcement with `secure`;
- Smaller CSRF attack surface with the new `SameSite` directive;
- The domain model (cookies are isolated per domain);

Expand Down
6 changes: 3 additions & 3 deletions docs/docs/contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ a few things you can do to help out:

- **Give us a star.** It may not seem like much, but it really makes a
difference. This is something that everyone can do to help out Ory Hydra.
Github stars help the project gain visibility and stand out.
GitHub stars help the project gain visibility and stand out.

- **Join the community.** Sometimes helping people can be as easy as listening
to their problems and offering a different perspective. Join our Slack, have a
Expand Down Expand Up @@ -150,13 +150,13 @@ request, go through this checklist:
1. Run `make format` if a `Makefile` is available, `gofmt -s` if the project is
written in Go, `npm run format` if the project is written for NodeJS.
1. Ensure that each commit has a descriptive prefix. This ensures a uniform
commit history and helps structure the changelog.
commit history and helps structure the changelog.
Please refer to this
[list of prefixes for Hydra](https://github.com/ory/hydra/blob/master/.github/semantic.yml)
for an overview.
1. Sign-up with CircleCI so that it has access to your repository with the
branch containing your PR. Simply creating a CircleCI account is sufficient
for the CI jobs to run, you do not need to setup a CircleCI project for the
for the CI jobs to run, you do not need to set up a CircleCI project for the
branch.

If a pull request is not ready to be reviewed yet
Expand Down
6 changes: 3 additions & 3 deletions docs/docs/faq.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ Since ORY Hydra 0.8.0, migrations are no longer run automatically on boot. This
is required in production environments, because:

1. Although SQL migrations are tested, migrating schemas can cause data loss and
should only be done consciously with prior back ups.
should only be done consciously with prior back-ups.
2. Running a production system with a user that has right such as ALTER TABLE is
a security anti-pattern.

Expand Down Expand Up @@ -273,7 +273,7 @@ Check the logs using `docker logs <container-id>`.
## Hydra won't remember my login

Hydra only keeps track of the session if you set the `remember_me` parameter in
the `accept login request`. Otherwise the login challenge will always instruct
the `accept login request`. Otherwise, the login challenge will always instruct
you to show the login UI.

## Where can I get documentation on running multiple instances of Hydra?
Expand All @@ -299,7 +299,7 @@ also some information on collecting statistics in the section on
Yes - you can configure that in your client. It has things like grant_types
etc - there you can basically whitelist the flows you need.

## How can i test if my 4445 is running properly?
## How can I test if my 4445 is running properly?

> I am using ory hydra for authentication. I get a 404 when im trying to create
> a client on my private EC2 hydra task. Is there a way to test if my 4445 is
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ repositories:
- [Go](https://github.com/ory/hydra-client-go)
- [Java](https://search.maven.org/artifact/sh.ory.hydra/hydra-client)
- [JavaScript](https://www.npmjs.com/package/@ory/hydra-client) with TypeScript
definitions and compatible with: NodeJS, ReactJS, AnuglarJS, Vue.js, and many
definitions and compatible with: NodeJS, ReactJS, AngularJS, Vue.js, and many
more.
- [PHP](https://packagist.org/packages/ory/hydra-client)
- [Python](https://pypi.org/project/ory-hydra-client/)
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/security-architecture.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ at rest, this is might only impose a problem if

### RS256

RSASSA-PKCS1-v1_5 using SHA-256 (RS256) is used to sign JWTs. It’s use is
RSASSA-PKCS1-v1_5 using SHA-256 (RS256) is used to sign JWTs. Its use is
recommended by the JWA specification, see
[https://www.rfc-editor.org/rfc/rfc7518.txt](https://www.rfc-editor.org/rfc/rfc7518.txt)

Expand Down