Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version info nil on version api endpoint #2894

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Conversation

zcmack
Copy link
Contributor

@zcmack zcmack commented Dec 18, 2021

This fix resolves #2337 and ensures the proper version number is included on the /version api endpoint. As per the discussion in the issue, it sources this data from driver\config\buildinfo.go and shows "master" when run locally / in docker.

Related issue(s)

#2337

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • [-] I have added tests that prove my fix is effective or that my feature
    works.
  • [-] I have added or changed the documentation.

Further Comments

I didn't add a test because I didn't see testing of the /health or /version endpoints outside of tls_termination_test.go but that doesn't seem like a logical place to put a simple payload validation test. Can certainly add one if an approach is recommended. No documentation changes as this is a bugfix and doesn't alter expected behaviors or processes.

@zcmack zcmack requested a review from aeneasr as a code owner December 18, 2021 01:09
@CLAassistant
Copy link

CLAassistant commented Dec 18, 2021

CLA assistant check
All committers have signed the CLA.

@aeneasr aeneasr merged commit 440e0b8 into ory:master Dec 22, 2021
@vinckr
Copy link
Member

vinckr commented Dec 22, 2021

Hello @zcmack
Congrats on merging your first PR in Ory!
We send all our first time contributors a gift package to welcome them to the community.
Please drop me a quick email and you get some Ory swag in no time: vincent@ory.sh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/verison endpoint does not return current service version
4 participants