fix: version info nil on version api endpoint #2894
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix resolves #2337 and ensures the proper version number is included on the
/version
api endpoint. As per the discussion in the issue, it sources this data fromdriver\config\buildinfo.go
and shows "master" when run locally / in docker.Related issue(s)
#2337
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments
I didn't add a test because I didn't see testing of the
/health
or/version
endpoints outside oftls_termination_test.go
but that doesn't seem like a logical place to put a simple payload validation test. Can certainly add one if an approach is recommended. No documentation changes as this is a bugfix and doesn't alter expected behaviors or processes.