-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OpenID Connect Dynamic Client Registration and OAuth2 Dynamic Client Registration Protocol #2909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # internal/httpclient/client/admin/admin_client.go # internal/httpclient/models/generic_error.go # spec/api.json # test/e2e/circle-ci.bash
aeneasr
changed the title
feat: openid connect dynamic client registration
feat: OpenID Connect Dynamic Client Registration
Jan 2, 2022
This feature adds first-class support for OpenID Connect Dynamic Client Registration. To enable this feature, which is disabled by default, set ```yaml oidc: dynamic_client_registration: enabled: true ``` in your Ory Hydra configuration. Once enabled, endpoints `POST`, `GET`, `PUT`, and `DELETE` for `/openid/register` will be available at the public port! Closes ory#2568 Closes ory#2549
BREAKING CHANGE: Endpoint `PUT /clients` now returns a 404 error when the OAuth2 Client to be updated does not exist. It return 401 previously.
aeneasr
changed the title
feat: OpenID Connect Dynamic Client Registration
feat: OpenID Connect Dynamic Client Registration and OAuth2 Dynamic Client Registration Protocol
Jan 3, 2022
Codecov Report
@@ Coverage Diff @@
## master #2909 +/- ##
==========================================
+ Coverage 77.95% 78.26% +0.30%
==========================================
Files 110 110
Lines 7636 7731 +95
==========================================
+ Hits 5953 6051 +98
+ Misses 1266 1265 -1
+ Partials 417 415 -2
Continue to review full report at Codecov.
|
@fjvierap thank you for your hard work! |
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds first-class support for two IETF RFCs and one OpenID Spec:
To enable this feature, which is disabled by default, set
in your Ory Hydra configuration. Once enabled, endpoints
POST
,GET
,PUT
, andDELETE
for/connect/register
will be available at the public port!Closes #2568
Closes #2549
@fjvierap thank you for the great PR! I have made some adjustments. In particular:
This PR still needs work:
Would you still be willing to help even though I needed so long to get this PR merged? :) If not I will try to complete it over the next few days / weeks.
Closes #2568
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments