-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TLS certs auto-reload #2910
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2910 +/- ##
==========================================
- Coverage 79.40% 78.60% -0.80%
==========================================
Files 112 112
Lines 7889 7971 +82
==========================================
+ Hits 6264 6266 +2
- Misses 1223 1302 +79
- Partials 402 403 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. I will wait to see things that have changed. In the meantime, if you have any recommendation on the coding style, please let me know. ;-) |
May I propose sth similar for kratos? |
Sure! :) You can also work on kratos first and then port this here |
In the meanwhile (while this is work in progress), I'll mark this as draft! |
Hi @aeneasr , Github seems quite buggy today. A lot of 500 are occurring, maybe because of Ukraine IDK. I have push the update synced with the latest master commit. I also added a small 2 second wait until all changes are made to avoid spam reload in the logs. As PR #2625 is merged and if it is ok for you we could avoid considering this as a Draft. ;-) |
5052f53
to
57c5a04
Compare
57c5a04
to
4019d10
Compare
@StarAurryon is this good for review now? :) |
@aeneasr Yes that's ok. But as you mention part of the code is shared with the Kratos PR too. Merging it to the right ory/x could be better. I am waiting for more instructions. |
I think that's the way to go forward :) |
#3265 was merged. There is no more need for this PR |
Kubernetes is able to auto-renew certificates with cert-manager and update files in the container. I would be cool if Ory Hydra could support auto certificate update on file change.
Related issue(s)
#2568
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments
Adds dependencies to fsnotify to support Mac/Windows/Linux.
This is an example of a working PoC. I need feedback ;-)