Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend latest and session related consents #3043

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aarmam
Copy link
Contributor

@aarmam aarmam commented Mar 23, 2022

This pull request introduces feature to extend consent validity time for both session related consent and subject related consent. Currently consent validity cannot be updated (when skip=true) or to be more precise - consent updates only if new device/browser accepts consent.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@aarmam aarmam requested a review from aeneasr as a code owner March 23, 2022 15:08
@aarmam aarmam force-pushed the feature/extend-consent-request branch from 1e65401 to d703604 Compare March 25, 2022 12:00
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #3043 (313256f) into master (3b1d87e) will increase coverage by 0.31%.
The diff coverage is 92.65%.

❗ Current head 313256f differs from pull request most recent head e6963be. Consider uploading reports for the commit e6963be to get more accurate results

@@            Coverage Diff             @@
##           master    #3043      +/-   ##
==========================================
+ Coverage   76.85%   77.16%   +0.31%     
==========================================
  Files         124      124              
  Lines        9162     9348     +186     
==========================================
+ Hits         7041     7213     +172     
- Misses       1672     1680       +8     
- Partials      449      455       +6     
Impacted Files Coverage Δ
consent/manager.go 100.00% <ø> (ø)
consent/handler.go 66.45% <50.00%> (-0.32%) ⬇️
persistence/sql/persister_consent.go 86.98% <83.87%> (-0.44%) ⬇️
consent/manager_test_helpers.go 98.18% <100.00%> (+0.25%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aarmam aarmam force-pushed the feature/extend-consent-request branch 2 times, most recently from 41326c0 to 72b8cba Compare April 3, 2022 17:50
@aarmam aarmam force-pushed the feature/extend-consent-request branch from 72b8cba to 37adf09 Compare April 19, 2022 07:59
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make this PR against the #2796 branch as we have done quite a lot of work on the DB layer and don't want to backport new changes to it as it has grown in scope significantly already. Thank you :)

@aarmam aarmam marked this pull request as draft May 6, 2022 08:24
@aarmam aarmam force-pushed the feature/extend-consent-request branch from 37adf09 to 3c07b1c Compare May 19, 2022 05:35
@aarmam aarmam force-pushed the feature/extend-consent-request branch 3 times, most recently from 0f125cc to 1933a0c Compare September 14, 2022 07:50
@aarmam aarmam marked this pull request as ready for review September 14, 2022 13:50
@aarmam aarmam force-pushed the feature/extend-consent-request branch 3 times, most recently from d2897e2 to c1e84a8 Compare September 15, 2022 12:05
@aarmam aarmam marked this pull request as draft September 15, 2022 12:31
@aarmam aarmam force-pushed the feature/extend-consent-request branch 3 times, most recently from 42d2ae7 to 70e1e72 Compare September 16, 2022 12:12
@aarmam aarmam marked this pull request as ready for review September 16, 2022 12:47
@aarmam aarmam force-pushed the feature/extend-consent-request branch from 70e1e72 to 8386cdc Compare October 21, 2022 09:21
@aarmam aarmam force-pushed the feature/extend-consent-request branch 2 times, most recently from 47cbb3c to 23621f4 Compare November 2, 2022 08:20
@aarmam aarmam marked this pull request as draft November 4, 2022 08:33
@aarmam aarmam force-pushed the feature/extend-consent-request branch from 23621f4 to fe7957a Compare November 4, 2022 13:11
@aarmam aarmam marked this pull request as ready for review November 4, 2022 14:33
@aarmam aarmam force-pushed the feature/extend-consent-request branch from fe7957a to 1f26dc6 Compare December 21, 2022 13:31
@aarmam aarmam requested a review from aeneasr December 21, 2022 14:00
@aarmam aarmam force-pushed the feature/extend-consent-request branch from 1f26dc6 to e6963be Compare April 5, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants