-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Updated Dockerfiles #3052
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3052 +/- ##
=======================================
Coverage 79.40% 79.40%
=======================================
Files 112 112
Lines 7889 7889
=======================================
Hits 6264 6264
Misses 1223 1223
Partials 402 402 Continue to review full report at Codecov.
|
Looks like there's a CVE in the new images: https://github.com/ory/hydra/runs/5788382665?check_suite_focus=true#step:10:37 |
So was that alpine:3.15.1 the problem? Hmmm that's strange because I did not changed it so how did it pass the tests so far? |
Thank you! Sometimes CVEs get found and break builds at random times, but your fixes look perfect now! :) |
Hello @adriang-90 |
I have changed some issues that I have found with hadolint, like condense RUN commands, changed ADD with COPY nr 7.
I also deleted some lines in
RUN apk add --no-cache
since it should be okay that way.Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments