Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Updated Dockerfiles #3052

Merged
merged 5 commits into from
Apr 5, 2022
Merged

refactor: Updated Dockerfiles #3052

merged 5 commits into from
Apr 5, 2022

Conversation

adriang-90
Copy link
Contributor

  • I have changed some issues that I have found with hadolint, like condense RUN commands, changed ADD with COPY nr 7.

  • I also deleted some lines in RUN apk add --no-cache since it should be okay that way.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@adriang-90 adriang-90 requested a review from aeneasr as a code owner March 31, 2022 20:33
@CLAassistant
Copy link

CLAassistant commented Mar 31, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #3052 (f6dcf06) into master (ff10e17) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3052   +/-   ##
=======================================
  Coverage   79.40%   79.40%           
=======================================
  Files         112      112           
  Lines        7889     7889           
=======================================
  Hits         6264     6264           
  Misses       1223     1223           
  Partials      402      402           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00100a1...f6dcf06. Read the comment docs.

aeneasr
aeneasr previously approved these changes Apr 1, 2022
test/conformance/hydra/Dockerfile Outdated Show resolved Hide resolved
@aeneasr
Copy link
Member

aeneasr commented Apr 1, 2022

@adriang-90
Copy link
Contributor Author

So was that alpine:3.15.1 the problem? Hmmm that's strange because I did not changed it so how did it pass the tests so far?

@aeneasr
Copy link
Member

aeneasr commented Apr 5, 2022

Thank you! Sometimes CVEs get found and break builds at random times, but your fixes look perfect now! :)

@aeneasr aeneasr merged commit 184d322 into ory:master Apr 5, 2022
@adriang-90 adriang-90 deleted the devops branch April 6, 2022 09:05
@vinckr
Copy link
Member

vinckr commented Apr 7, 2022

Hello @adriang-90
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants