Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enables multiple clients log in at the same time #3060

Closed
wants to merge 3 commits into from

Conversation

sidharthramesh
Copy link

Creates a client-specific CSRF session. This enables multiple clients to log in at the same time.

Related issue(s)

Fixes #3019

Similar to PR #3059

Checklist

  • [ x ] I have read the contributing guidelines.
  • [ x ] I have referenced an issue containing the design document if my change
    introduces a new feature.
  • [ x ] I am following the
    contributing code guidelines.
  • [ x ] I have read the security policy.
  • [ x ] I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • [ x ] I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2022

CLA assistant check
All committers have signed the CLA.

@sidharthramesh sidharthramesh changed the title Fixes CSRF error when multiple clients log in at the same time feat: enables multiple clients log in at the same time Apr 7, 2022
@sidharthramesh
Copy link
Author

sidharthramesh commented Apr 7, 2022

Actually, I feel #3059 by @aarmam is less hacky than my solution here. Recommending that to be merged.

@aeneasr
Copy link
Member

aeneasr commented Apr 8, 2022

Thank you very much for your contribution! As you said, I feel a bit more comfortable with #3059 so I'll close this one here :)

@aeneasr aeneasr closed this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to perform simultaneous auth flows with different clients
3 participants