Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jwk generator checks were never executed. fixed that and some checks. #3061

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

like-a-bause
Copy link
Contributor

@like-a-bause like-a-bause commented Apr 7, 2022

The tests for jwk generators had a logic flip and checks were never executed. Fixed that and some basic test logic.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@like-a-bause like-a-bause requested a review from aeneasr as a code owner April 7, 2022 08:47
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #3061 (8ab277e) into master (184d322) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 8ab277e differs from pull request most recent head 5c19fd3. Consider uploading reports for the commit 5c19fd3 to get more accurate results

@@            Coverage Diff             @@
##           master    #3061      +/-   ##
==========================================
- Coverage   79.42%   79.40%   -0.03%     
==========================================
  Files         112      112              
  Lines        7889     7889              
==========================================
- Hits         6266     6264       -2     
- Misses       1222     1223       +1     
- Partials      401      402       +1     
Impacted Files Coverage Δ
persistence/sql/persister_oauth2.go 81.01% <0.00%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1056795...5c19fd3. Read the comment docs.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thank you!

@aeneasr aeneasr merged commit d38f6e6 into ory:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants