Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add limit and offset to pagination #3062

Merged
merged 1 commit into from
Apr 11, 2022
Merged

fix: add limit and offset to pagination #3062

merged 1 commit into from
Apr 11, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Apr 11, 2022

Closes #3033

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr self-assigned this Apr 11, 2022
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #3062 (adc0ed0) into master (d38f6e6) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head adc0ed0 differs from pull request most recent head 7ebcfec. Consider uploading reports for the commit 7ebcfec to get more accurate results

@@            Coverage Diff             @@
##           master    #3062      +/-   ##
==========================================
+ Coverage   79.38%   79.40%   +0.01%     
==========================================
  Files         112      112              
  Lines        7889     7889              
==========================================
+ Hits         6263     6264       +1     
  Misses       1223     1223              
+ Partials      403      402       -1     
Impacted Files Coverage Δ
persistence/sql/persister_oauth2.go 81.01% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b00d2b9...7ebcfec. Read the comment docs.

@aeneasr aeneasr merged commit 51f6c5d into master Apr 11, 2022
@aeneasr aeneasr deleted the close-3033 branch April 11, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Lists All Consent Sessions of a Subject" is missing query parameters
1 participant