Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: standardize license headers #3216

Merged
merged 18 commits into from
Nov 3, 2022
Merged

Conversation

kevgo
Copy link
Contributor

@kevgo kevgo commented Aug 3, 2022

Add a license header to all source code files.

Related issue(s)

https://github.com/ory-corp/general/issues/602

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

This is just a demo of the capability for now. Please provide feedback to fine-tune the generated headers.

@kevgo kevgo mentioned this pull request Aug 3, 2022
6 tasks
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #3216 (7560617) into master (f8a7ced) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 7560617 differs from pull request most recent head b65083c. Consider uploading reports for the commit b65083c to get more accurate results

@@           Coverage Diff           @@
##           master    #3216   +/-   ##
=======================================
  Coverage   76.86%   76.86%           
=======================================
  Files         123      123           
  Lines        8920     8922    +2     
=======================================
+ Hits         6856     6858    +2     
- Misses       1636     1637    +1     
+ Partials      428      427    -1     
Impacted Files Coverage Δ
client/client.go 75.75% <ø> (ø)
client/handler.go 78.44% <ø> (ø)
client/manager_test_helpers.go 98.51% <ø> (ø)
client/validator.go 72.64% <ø> (ø)
cmd/cli/error.go 0.00% <ø> (ø)
cmd/cli/handler.go 100.00% <ø> (ø)
cmd/cli/handler_helper.go 57.89% <ø> (ø)
cmd/cli/handler_janitor.go 80.85% <ø> (ø)
cmd/cli/handler_jwk.go 100.00% <ø> (ø)
cmd/cli/handler_migrate.go 1.04% <ø> (ø)
... and 115 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kevgo kevgo force-pushed the kg-license-headers branch from e8db3c2 to 016abc7 Compare September 9, 2022 17:47
@aeneasr
Copy link
Member

aeneasr commented Sep 10, 2022

Could you exclude autogenerated files in internal/httpclient please? :)

@kevgo kevgo closed this Sep 13, 2022
@kevgo kevgo force-pushed the kg-license-headers branch from 1d6060a to c68e130 Compare September 13, 2022 19:49
@kevgo kevgo reopened this Sep 13, 2022
@kevgo
Copy link
Contributor Author

kevgo commented Sep 13, 2022

Great feedback to exclude auto-generated files! ory/cli#214 adds the missing feature. The changes in this PR are a preview of how this would look like. They were created by running:

ory dev headers license --exclude=internal/httpclient

@kevgo kevgo force-pushed the kg-license-headers branch from 28c914f to 66f3f3e Compare September 13, 2022 20:45
@kevgo
Copy link
Contributor Author

kevgo commented Oct 7, 2022

Blocking on shipping ory/cli#239 as a new Ory CLI version.

kevgo added 13 commits October 12, 2022 15:45
…o sdk_test.go validator.go validator_test.go handler.go handler_helper.go handler_jwk.go cmd_create_client.go cmd_create_jwks.go cmd_delete_client.go cmd_delete_jwks.go cmd_delete_tokens.go cmd_get_client.go cmd_get_jwks.go cmd_import_client.go cmd_introspect_token.go cmd_perform_authorization_code.go cmd_perform_client_credentials.go cmd_revoke_token.go helper.go migrate.go migrate_sql.go root.go serve.go banner.go handler.go helper_cert.go version.go handler.go handler_test.go helper.go helper_test.go manager.go manager_test_helpers.go sdk_test.go strategy.go strategy_default.go strategy_default_test.go subject_identifier_algorithm.go subject_identifier_algorithm_pairwise.go subject_identifier_algorithm_public.go types.go doc.go mock_generator_rs256.go aead.go aead_test.go cast.go cast_test.go generator.go handler.go handler_test.go helper.go helper_test.go jwt_strategy.go jwt_strategy_test.go manager.go manager_test_helpers.go sdk_test.go main.go equalKeys.go equalKeys_test.go fosite_store_helpers.go fosite_store_test.go handler.go handler_fallback_endpoints.go handler_fallback_endpoints_test.go handler_test.go introspector.go introspector_test.go oauth2_auth_code_test.go oauth2_client_credentials_test.go oauth2_helper_test.go oauth2_jwt_bearer_test.go revocator_test.go session.go doc.go manager_test_helpers.go main.go main.go main.go basic_auth.go doc.go doc_swagger.go error_enhancer_test.go errors.go errors_test.go fosite_storer.go hasher.go cors.go cors_test.go secret.go test_helpers.go
@kevgo kevgo changed the title docs: add license headers to all files docs: standardize license headers Nov 3, 2022
@kevgo kevgo marked this pull request as ready for review November 3, 2022 11:43
@kevgo kevgo requested a review from aeneasr as a code owner November 3, 2022 11:43
@kevgo kevgo merged commit d768cf6 into ory:master Nov 3, 2022
@kevgo kevgo deleted the kg-license-headers branch November 3, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants