Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove special char from snapshot symbols #3229

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

mih-kopylov
Copy link
Contributor

The Pull Request is a backport of a commit that renames the snapshot files that are not supported by Windows

See the discussion in #3204

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@mih-kopylov
Copy link
Contributor Author

@aeneasr it looks like some linting rules are not met in master branch, but that is not introduced with this PR
https://github.com/ory/hydra/runs/8014301049?check_suite_focus=true#step:11:30

Can we merge this PR please, so that master branch has fixes for Windows?

@aeneasr aeneasr force-pushed the remove-special-char branch from 476ccb7 to 5f5036a Compare August 25, 2022 11:39
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #3229 (3bb943a) into master (2d080a0) will decrease coverage by 0.06%.
The diff coverage is 61.90%.

❗ Current head 3bb943a differs from pull request most recent head 1853a3b. Consider uploading reports for the commit 1853a3b to get more accurate results

@@            Coverage Diff             @@
##           master    #3229      +/-   ##
==========================================
- Coverage   79.32%   79.25%   -0.07%     
==========================================
  Files         111      111              
  Lines        8084     8105      +21     
==========================================
+ Hits         6413     6424      +11     
- Misses       1258     1263       +5     
- Partials      413      418       +5     
Impacted Files Coverage Δ
oauth2/session.go 80.00% <61.90%> (-9.75%) ⬇️
persistence/sql/persister_oauth2.go 79.09% <0.00%> (-0.82%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

aeneasr
aeneasr previously approved these changes Aug 25, 2022
@aeneasr aeneasr force-pushed the remove-special-char branch from 5f5036a to 1853a3b Compare August 25, 2022 12:17
@aeneasr aeneasr merged commit 7128ad2 into ory:master Aug 25, 2022
@vinckr
Copy link
Member

vinckr commented Sep 5, 2022

Hello @mih-kopylov
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants