cmd: replace newline in HTTP_TLS #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTPS_TLS_CERT and HTTPS_TLS_KEY environment variables can contain \n see:https://github.com/ory-am/hydra/blob/master/cmd/host.go This commit replaces the \n character with an actual newline to allow the tls package to correctly create a X509 key pair. Signed-off-by: Edward Wilde <ewilde@gmail.com>
|
Does this work on windows / linux / osx alike? |
|
Because windows has |
|
I will test it on windows and get back to you. I've only tried it on mac and linux |
|
Seems to load okay on window
See 'Loaded certificate from environment variable' at the bottom |
|
Cool, thanks for investigating! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTPS_TLS_CERT and HTTPS_TLS_KEY environment variables can contain
\nsee:https://github.com/ory-am/hydra/blob/master/cmd/host.go
This commit replaces the
\ncharacters with an actual newline to allowthe tls package to correctly create a X509 key pair.
Otherwise the X509 key pair fails to get created.
Signed-off-by: Edward Wilde ewilde@gmail.com