chore: list contributors in file #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3345 +/- ##
==========================================
+ Coverage 76.84% 76.86% +0.02%
==========================================
Files 123 123
Lines 8922 8922
==========================================
+ Hits 6856 6858 +2
+ Misses 1638 1637 -1
+ Partials 428 427 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
grantzvolsky
reviewed
Nov 9, 2022
| @@ -92,6 +92,9 @@ quicktest: | |||
| quicktest-hsm: | |||
| docker build --progress=plain -f .docker/Dockerfile-hsm --target test-hsm . | |||
|
|
|||
| authors: # updates the AUTHORS file | |||
| curl https://raw.githubusercontent.com/ory/ci/master/authors/authors.sh | env PRODUCT="Ory Hydra" bash | |||
There was a problem hiding this comment.
-
Consider removing
https://github.com/ory/hydra/blob/48603bac894bad157501e609c8f694e8ff17da70/Makefile#L183if it is made obsolete by this. -
The new implementation ignores
.mailmap(%aN,%aE). -
The new implementation doesn't check for shallow repositories. This can be a problem when CI makes commits.
There was a problem hiding this comment.
Grant!! Thanks for this super helpful review!
- chore: consider .mailmap file for authors ci#142 adds the
.mailmapsupport - chore: enforce full Git history for authors ci#143 adds the check for complete Git history
- this PR now removes the
contributorstarget
aeneasr
approved these changes
Nov 10, 2022
harnash
pushed a commit
to Wikia/ory-hydra
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
https://github.com/ory-corp/general/issues/732
Checklist
and signed the CLA.
introduces a new feature.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
appropriate).