Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend session lifespan on session refresh (skip=true) #3464

Merged
merged 6 commits into from
Mar 16, 2023
Merged

feat: extend session lifespan on session refresh (skip=true) #3464

merged 6 commits into from
Mar 16, 2023

Conversation

sgal
Copy link
Contributor

@sgal sgal commented Mar 11, 2023

Related issue(s)

Picking up work done in #2848 to speed up the delivery, since the author is on vacation.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@sgal sgal changed the title Refresh remember on use feat: extend session lifespan on session refresh (skip=true) Mar 11, 2023
@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Merging #3464 (3ca488a) into master (a4e2da5) will increase coverage by 2.91%.
The diff coverage is 100.00%.

❗ Current head 3ca488a differs from pull request most recent head 57387db. Consider uploading reports for the commit 57387db to get more accurate results

@@            Coverage Diff             @@
##           master    #3464      +/-   ##
==========================================
+ Coverage   73.91%   76.83%   +2.91%     
==========================================
  Files         123      123              
  Lines        9553     9125     -428     
==========================================
- Hits         7061     7011      -50     
+ Misses       2040     1666     -374     
+ Partials      452      448       -4     
Impacted Files Coverage Δ
consent/types.go 78.12% <ø> (+11.45%) ⬆️
consent/strategy_default.go 69.50% <100.00%> (+9.95%) ⬆️
flow/flow.go 92.39% <100.00%> (+0.21%) ⬆️

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sgal sgal marked this pull request as ready for review March 11, 2023 17:08
@sgal sgal requested a review from aeneasr as a code owner March 11, 2023 17:08
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a migration test file for the new migration :)

consent/types.go Outdated Show resolved Hide resolved
@sgal
Copy link
Contributor Author

sgal commented Mar 15, 2023

@aeneasr Added migration test and fixed comments, please have a look!

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thank you very much!

@aeneasr aeneasr merged commit 7511436 into ory:master Mar 16, 2023
@sgal sgal deleted the refresh-remember-on-use branch March 16, 2023 12:07
harnash pushed a commit to Wikia/ory-hydra that referenced this pull request Apr 12, 2023
It is now possible to extend session lifespans when accepting login challenges.

Closes ory#1690
Closes ory#1557
Closes ory#2246
Closes ory#2848

Co-authored-by: Mart Aarma <mart.aarma@nortal.com>
Co-authored-by: Henning Perl <henning.perl@gmail.com>
Co-authored-by: ory-bot <60093411+ory-bot@users.noreply.github.com>
alarkvell pushed a commit to e-gov/GovSSO-Session that referenced this pull request Nov 28, 2023
alarkvell pushed a commit to e-gov/GovSSO-Session that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants