Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce SQL tracing noise #3481

Merged
merged 1 commit into from
Apr 6, 2023
Merged

fix: reduce SQL tracing noise #3481

merged 1 commit into from
Apr 6, 2023

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Apr 4, 2023

This silences sql-rows-next spans in tracing, which don't have any real informational value but can make up a large portion of all spans.

@alnr alnr self-assigned this Apr 4, 2023
@alnr alnr requested a review from aeneasr as a code owner April 4, 2023 12:34
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #3481 (b9d169f) into master (3b1d87e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head b9d169f differs from pull request most recent head 86a691a. Consider uploading reports for the commit 86a691a to get more accurate results

@@            Coverage Diff             @@
##           master    #3481      +/-   ##
==========================================
- Coverage   76.85%   76.83%   -0.02%     
==========================================
  Files         124      124              
  Lines        9162     9164       +2     
==========================================
  Hits         7041     7041              
- Misses       1672     1673       +1     
- Partials      449      450       +1     
Impacted Files Coverage Δ
driver/registry_sql.go 74.73% <100.00%> (+0.54%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 6e1f545 into master Apr 6, 2023
@aeneasr aeneasr deleted the sql-tracing branch April 6, 2023 07:36
harnash pushed a commit to Wikia/ory-hydra that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants