Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing persister_grant_jwk having an OR statement without bracket leading to not using the last part of the query #3499

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

StarAurryon
Copy link
Contributor

@StarAurryon StarAurryon commented Apr 21, 2023

No breaking change, just a fix

Related issue(s)

#3498

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

None

…racket leading to not using the last part of the query
@StarAurryon StarAurryon changed the title fix(sql): fixing persister_grant_jwk having an OR statement without bracket leading to not using the last part of the query fix: fixing persister_grant_jwk having an OR statement without bracket leading to not using the last part of the query Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #3499 (fc89afc) into master (cf20054) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head fc89afc differs from pull request most recent head 40c0725. Consider uploading reports for the commit 40c0725 to get more accurate results

@@            Coverage Diff             @@
##           master    #3499      +/-   ##
==========================================
- Coverage   76.87%   76.82%   -0.05%     
==========================================
  Files         124      124              
  Lines        9175     9175              
==========================================
- Hits         7053     7049       -4     
- Misses       1673     1675       +2     
- Partials      449      451       +2     
Impacted Files Coverage Δ
persistence/sql/persister_grant_jwk.go 89.85% <100.00%> (-1.45%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit 13ce0d6 into ory:master Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants