feat: hot-reload Oauth2 CORS settings #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3537 +/- ##
==========================================
- Coverage 79.41% 76.83% -2.59%
==========================================
Files 129 124 -5
Lines 11368 9108 -2260
==========================================
- Hits 9028 6998 -2030
+ Misses 1779 1668 -111
+ Partials 561 442 -119
|
aeneasr
reviewed
Jun 7, 2023
zepatrik
force-pushed
the
feat/hot-reload-oauth2-cors
branch
2 times, most recently
from
6474179
to
d418ce0
Compare
zepatrik
force-pushed
the
feat/hot-reload-oauth2-cors
branch
from
d418ce0
to
12cc543
Compare
aeneasr
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As client settings change over time, this should be fully hot-reloadable. Resolves regression of #1754 on Ory Network.