Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add kid to verifiable credential header #3606

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Aug 15, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from aeneasr as a code owner August 15, 2023 08:15
@hperl hperl self-assigned this Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #3606 (96ec017) into master (c004fee) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 57.14%.

❗ Current head 96ec017 differs from pull request most recent head 5ed5f67. Consider uploading reports for the commit 5ed5f67 to get more accurate results

@@            Coverage Diff             @@
##           master    #3606      +/-   ##
==========================================
- Coverage   76.28%   76.26%   -0.02%     
==========================================
  Files         132      132              
  Lines        9984     9990       +6     
==========================================
+ Hits         7616     7619       +3     
- Misses       1848     1850       +2     
- Partials      520      521       +1     
Files Changed Coverage Δ
oauth2/handler.go 67.42% <57.14%> (-0.21%) ⬇️

@aeneasr aeneasr merged commit 9f1c8d1 into master Aug 16, 2023
@aeneasr aeneasr deleted the hperl/oidc-vc-add-kid branch August 16, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants