Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduces alpine based docker image #704

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Reintroduces alpine based docker image #704

merged 1 commit into from
Dec 12, 2017

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 12, 2017

Closes #703

@rio
Copy link

rio commented Dec 12, 2017

Nice, i was actually doing the same thing but I noticed you were using build args so I just changed the FROM scratch into FROM $base_image and added another docker build command. I tend to DRY alot :P

@aeneasr
Copy link
Member Author

aeneasr commented Dec 12, 2017

Ha nice, feel free to update this after merge :)

@rio
Copy link

rio commented Dec 12, 2017

Ah sorry my bad, doesn't seem to work with FROM statements...

@aeneasr aeneasr merged commit 0d47938 into master Dec 12, 2017
@aeneasr aeneasr deleted the add-alpine branch December 12, 2017 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants