sdk: Generate php sdk and point php autoloader to lib folder #736
Conversation
|
That look pretty solid already, thank you! Could you add a quick guide on how to instantiate this to docs/sdk/php.md? |
|
ping @pnicolcev-tulipretail :) |
pnicolcev-tulipretail
force-pushed
the
gen-php-sdk
branch
5 times, most recently
from
649f3c0 to
7eb75bd
Compare
Add docs/sdk/php.md Signed-off-by: Philip Nicolcev <phil.nicolcev@tulip.io>
pnicolcev-tulipretail
force-pushed
the
gen-php-sdk
branch
from
7eb75bd to
513087f
Compare
|
@arekkas I'm here! Added and squashed. You may also want to fork/take ownership of the oauth2 client: https://github.com/tulipretail/oauth2-hydra which is referenced in the php.md. Also please register on packagist.org and submit this sdk once you merge so that composer users have an easier time pulling in your sdk. |
There was a problem hiding this comment.
Thank you! That looks pretty solid. I registered at packagist here: https://packagist.org/packages/ory/hydra-sdk
docs/sdk/php.md
Outdated
| ```json | ||
| { | ||
| "repositories": { | ||
| "tulip/hydra-php-sdk": { "type": "vcs", "url": "git@git.internal.tulip.io:shared/composer-libraries/hydra-php-sdk.git" } |
There was a problem hiding this comment.
I guess this can be updated? I registered packagist here: https://packagist.org/packages/ory/hydra-sdk
There was a problem hiding this comment.
Oops, the above was from internal testing. Fixed this reference to your packagist repo.
| client that has had this work done for us. | ||
|
|
||
| ```sh | ||
| composer require tulip/oauth2-hydra |
There was a problem hiding this comment.
Different repo. I can change the org to ory but maybe it's better if you take ownership if it's official. You can fork this guy https://github.com/tulipretail/oauth2-hydra, change tulip/oauth2-hydra to ory/oauth2-hydra in composer.json and submit it to packagist.
You could also make it official by making a PR to add it to the league's list https://github.com/thephpleague/oauth2-client/blob/master/docs/providers/thirdparty.md
|
Thank you! |
|
This PR was made against master which is currently scheduled for the first alpha of 1.0.0, but that will take a some time before being published. Could you re-open this PR against the |
|
Damn, I see that the branch was deleted... Maybe you have a backup locally? |
|
Hm, I just restored it. Will try opening one to 0.11 |
Generate php sdk and include it in the project.
Point php autoloader to lib folder.