Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client secret expires #870

Merged
merged 7 commits into from
May 25, 2018
Merged

Client secret expires #870

merged 7 commits into from
May 25, 2018

Conversation

zepatrik
Copy link
Member

introduces the client_secret_expires_at field without any functionality
it should always be 0
closes #778

@aeneasr
Copy link
Member

aeneasr commented May 23, 2018

Tests fail

aeneasr
aeneasr reviewed May 23, 2018
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zepatrik please add a test that checks if client_secret_expires_at is properly stored in the storage adapter by making changes to manager_test

@aeneasr aeneasr merged commit 56aa5d2 into ory:master May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client: Add field client_secret_expires_at to create
2 participants
@zepatrik @aeneasr