Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.1-beta2 #90

Merged
merged 32 commits into from
Jun 14, 2016
Merged

0.1-beta2 #90

merged 32 commits into from
Jun 14, 2016

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jun 3, 2016 •
edited
Loading

This release has backwards compability issues, because the system secret generation algorithm has changed. See #86

  • import tls certificates
  • document tls import
  • store certificates in jwk store
  • key / env should override store jwks! (use case: started without cert, added cert later to container)
  • remove secret flag
  • clients import clients.json
  • wait for x5c / x5t parameters square/go-jose#95
  • offline scope
  • allow http only
  • add --dry option
  • mailchimp

Aeneas Rekkas (arekkas) added 2 commits June 3, 2016 09:49
@aeneasr aeneasr added the feat New feature or request. label Jun 3, 2016
@aeneasr aeneasr added this to the 0.1-beta2 milestone Jun 3, 2016
@aeneasr aeneasr self-assigned this Jun 3, 2016
@aeneasr aeneasr added the breaking change Changes behavior in a breaking manner. label Jun 3, 2016
@aeneasr
Copy link
Member Author

aeneasr commented Jun 8, 2016

I think it would be good to wait for square/go-jose#95 to be implemented before this gets merged. The current workaround feels hacky

Aeneas Rekkas (arekkas) and others added 3 commits June 8, 2016 13:16
@aeneasr
Copy link
Member Author

aeneasr commented Jun 9, 2016

ory/fosite#48

Aeneas Rekkas (arekkas) added 2 commits June 9, 2016 14:44
@aeneasr
Copy link
Member Author

aeneasr commented Jun 13, 2016

👐 square/go-jose#95 is now merged. let's roll

@aeneasr
Copy link
Member Author

aeneasr commented Jun 14, 2016 

go run main.go keys create foo123 --dry --skip-tls-verify
Warning: Skipping TLS Certificate Verification.
Could not generate keys: Because you are using the dry option, the request will not be executed. You can execute this command using:

curl -X POST -d "{\"alg\":\"\",\"keys\":null}" -H "Content-Type: application/json" 'https://localhost:4444/keys/foo123

@aeneasr aeneasr merged commit 8593699 into master Jun 14, 2016
@aeneasr aeneasr deleted the 0.1-beta2 branch July 25, 2016 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aeneasr aeneasr

Labels
breaking change Changes behavior in a breaking manner. feat New feature or request.
Projects
None yet
Milestone
0.1-beta2
Development

Successfully merging this pull request may close these issues.
1 participant
@aeneasr