cmd: Disable CORS by default #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
added
bug
This patch introduces environment variable `CORS_ENABLED` which toggles CORS. Closes #996 Signed-off-by: arekkas <aeneas@ory.am>
|
Unsubscribe
…On Tue, Aug 21, 2018, 4:57 AM hackerman ***@***.***> wrote:
This patch introduces environment variable CORS_ENABLED which toggles
CORS.
Closes #996 <#996>
------------------------------
You can view, comment on, or merge this pull request online at:
#997
Commit Summary
- cmd: Disable CORS by default
File Changes
- *M* UPGRADE.md <https://github.com/ory/hydra/pull/997/files#diff-0>
(7)
- *M* cmd/serve.go <https://github.com/ory/hydra/pull/997/files#diff-1>
(5)
- *M* cmd/server/handler.go
<https://github.com/ory/hydra/pull/997/files#diff-2> (8)
Patch Links:
- https://github.com/ory/hydra/pull/997.patch
- https://github.com/ory/hydra/pull/997.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#997>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AofxNlIqIE07OrehtC-swqD1Hhd6grIiks5uS9mGgaJpZM4WFd0i>
.
|
|
Unsubscribe
…On Tue, Aug 21, 2018, 5:13 AM hackerman ***@***.***> wrote:
Merged #997 <#997> into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#997 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AofxNiVT_t8QSQyOWJqGY89tLTFRhBSHks5uS902gaJpZM4WFd0i>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces environment variable
CORS_ENABLEDwhich toggles CORS.Closes #996