fix: store provider

ory · Aug 27, 2024 · ceff2da · ceff2da
1 parent 872581e
commit ceff2da
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/selfservice/strategy/oidc/.snapshots/TestStrategy-method=TestPopulateSignUpMethod.json b/selfservice/strategy/oidc/.snapshots/TestStrategy-method=TestPopulateSignUpMethod.json
@@ -130,18 +130,18 @@
  "attributes": {
  "name": "provider",
  "type": "submit",
- "value": "neverPKCE",
+ "value": "forcePKCE",
  "disabled": false,
  "node_type": "input"
  },
  "messages": [],
  "meta": {
  "label": {
  "id": 1040002,
- "text": "Sign up with neverPKCE",
+ "text": "Sign up with forcePKCE",
  "type": "info",
  "context": {
- "provider": "neverPKCE"
+ "provider": "forcePKCE"
  }
  }
  }

diff --git a/selfservice/strategy/oidc/strategy_login.go b/selfservice/strategy/oidc/strategy_login.go
@@ -279,6 +279,10 @@ func (s *Strategy) Login(w http.ResponseWriter, r *http.Request, f *login.Flow,
  span.SetAttributes(attribute.Bool("pkce", ok))
  }
 
+ if err := storeProvider(f, pid); err != nil {
+ return nil, s.handleError(w, r, f, pid, nil, errors.WithStack(herodot.ErrInternalServerError.WithReason("Could not update flow context").WithDebug(err.Error())))
+ }
+
  f.Active = s.ID()
  if err = s.d.LoginFlowPersister().UpdateLoginFlow(ctx, f); err != nil {
  return nil, s.handleError(w, r, f, pid, nil, errors.WithStack(herodot.ErrInternalServerError.WithReason("Could not update flow").WithDebug(err.Error())))