You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Makefile uses a quickstart binary in the quickstart and quickstart-dev targets.
This change was introduced in #2206.
It looks to me, as if the change was initially planned to include a quickstart binary in the EXECUTABLES line, as is shown in the review to #2206.
I don't know if this is just a plain mistake or if some software package actually includes a quickstart binary that works as a replacement for docker-compose. I could not find anything googling for a quickstart binary (but as this is a very generic term, it is actually hard to find something specific).
My suggestion would be, to change this back to using Compose.
Ideally this would be the new Compose v2, which is called via docker compose and not docker-compose anymore.
Also, the docker build command in the quickstart-dev target is different from the line in the docker target.
I would suggest to just have the quickstart-dev target depend on the docker target.
I am happy to create a PR changing the Makefile but would like to clarify this here before.
Reproducing the bug
Run make quickstart in kratos directory
Command fails with /bin/bash: line 1: quickstart: command not found
Relevant log output
No response
Relevant configuration
No response
Version
Current master, but bug present since v0.9.0
On which operating system are you observing this issue?
No response
In which environment are you deploying?
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered:
Preflight checklist
Describe the bug
The
Makefile
uses aquickstart
binary in thequickstart
andquickstart-dev
targets.This change was introduced in #2206.
It looks to me, as if the change was initially planned to include a
quickstart
binary in theEXECUTABLES
line, as is shown in the review to #2206.I don't know if this is just a plain mistake or if some software package actually includes a
quickstart
binary that works as a replacement fordocker-compose
. I could not find anything googling for a quickstart binary (but as this is a very generic term, it is actually hard to find something specific).My suggestion would be, to change this back to using Compose.
Ideally this would be the new Compose v2, which is called via
docker compose
and notdocker-compose
anymore.Also, the
docker build
command in thequickstart-dev
target is different from the line in thedocker
target.I would suggest to just have the
quickstart-dev
target depend on thedocker
target.I am happy to create a PR changing the Makefile but would like to clarify this here before.
Reproducing the bug
make quickstart
in kratos directory/bin/bash: line 1: quickstart: command not found
Relevant log output
No response
Relevant configuration
No response
Version
Current master, but bug present since v0.9.0
On which operating system are you observing this issue?
No response
In which environment are you deploying?
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: