Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JSON Schema Validation Errors #413

Closed
aeneasr opened this issue May 14, 2020 · 0 comments · Fixed by #414
Closed

Improve JSON Schema Validation Errors #413

aeneasr opened this issue May 14, 2020 · 0 comments · Fixed by #414
Labels
feat New feature or request. help wanted We are looking for help on this one.
Milestone
unplanned

Comments

@aeneasr
Copy link
Member

aeneasr commented May 14, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.

Right now it is difficult to identify the source of validation errors.

Describe the solution you'd like

We should show an excerpt of the config and add a clear indicator what's wrong. For example:

...
urls:
  login_ui: https://foo.bar/
  settings_ui: 1234
               ^ should be uri but is number
@aeneasr aeneasr added feat New feature or request. help wanted We are looking for help on this one. up for grab labels May 14, 2020
@aeneasr aeneasr added this to the unplanned milestone May 14, 2020
aeneasr added a commit that referenced this issue May 14, 2020
@aeneasr
fix: improve config validation error message
453234d 
Closes #413
@aeneasr aeneasr mentioned this issue May 14, 2020
Merged
aeneasr added a commit that referenced this issue May 15, 2020
@aeneasr
fix: improve config validation error message (#414)
d1e6896 
Closes #413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat New feature or request. help wanted We are looking for help on this one.
Projects
None yet
Milestone
unplanned
Development

Successfully merging a pull request may close this issue.

fix: improve config validation error message ory/kratos
1 participant
@aeneasr