Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building From Source fails #711

Closed
leadiato opened this issue Sep 30, 2020 · 8 comments
Closed

Building From Source fails #711

leadiato opened this issue Sep 30, 2020 · 8 comments
Labels
bug Something is not working. good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.

Comments

@leadiato
Copy link

Describe the bug
Building Kratos from source fails when following Kratos Building from source

Reproducing the bug
Steps to reproduce the behavior:

  1. run go get -d -u github.com/ory/kratos
  2. cd $(go env GOPATH)/src/github.com/ory/kratos
  3. GO111MODULE=on make install

Output:
make: *** No rule to make target '.bin/packr2', needed by 'install'. Stop.

Expected behavior

$(go env GOPATH)/bin/kratos help runs successfully and returns proper version number

Environment

  • Environment: Mac OS 10.14.6
  • Make: GNU Make 4.3
  • Go: go1.15.2 darwin/amd64
@aeneasr
Copy link
Member

aeneasr commented Sep 30, 2020

@aeneasr aeneasr closed this as completed Sep 30, 2020
@aeneasr aeneasr reopened this Sep 30, 2020
@aeneasr
Copy link
Member

aeneasr commented Sep 30, 2020

Sorry, looks like you're following the guide!

@aeneasr aeneasr added bug Something is not working. docs labels Sep 30, 2020
@leadiato
Copy link
Author

leadiato commented Oct 1, 2020

To fix the issue I had to manually create 2 folders (.bin/packr2 & .bin/pack) prior to start the build.

@aeneasr aeneasr added good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one. labels Oct 2, 2020
@aeneasr aeneasr added this to the v0.6.0-alpha.1 milestone Oct 2, 2020
@aeneasr
Copy link
Member

aeneasr commented Oct 2, 2020

Would you be open to contribute that change to the Makefile? :)

@chris-rock
Copy link

The make tools mentioned in the docs is also not working.

@aeneasr
Copy link
Member

aeneasr commented Oct 7, 2020

Could you please provide more details? What make version, what is "not working" (error message please), where in the docs - and so on! :) I can only help if sufficient details are provided, otherwise it's a guessing game.

@chris-rock
Copy link

No problemo. There is a reference to make tool in https://github.com/ory/kratos/blob/master/README.md#install-tools It seems that there is no tools task in the latest Makefile. With the changes in #750 I got the binary compiled.

aeneasr added a commit that referenced this issue Oct 11, 2020
This task does not exist any more and the dependency building is much smarter now.

See #711
Closes #750
@aeneasr
Copy link
Member

aeneasr commented Oct 11, 2020

Ok so make tools no longer exists - these things now compile automatically (e.g. "golangci-lint" or "goreturns"). Another problem was that we no longer use packr2 so it's not listed as a dependency and thus shouldn't be required!

aeneasr added a commit that referenced this issue Oct 11, 2020
aeneasr added a commit that referenced this issue Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working. good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.
Projects
None yet
Development

No branches or pull requests

3 participants