Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email templating docs link broken #835

Closed
zepatrik opened this issue Nov 18, 2020 · 10 comments · Fixed by #893
Closed

Email templating docs link broken #835

zepatrik opened this issue Nov 18, 2020 · 10 comments · Fixed by #893
Assignees
Labels
bug Something is not working. corp/m4 Up for M4 at Ory Corp.

Comments

@zepatrik
Copy link
Member

@zepatrik zepatrik added bug Something is not working. docs labels Nov 18, 2020
@aeneasr aeneasr assigned vinckr and unassigned Bin-fluence Nov 19, 2020
@vinckr
Copy link
Member

vinckr commented Nov 19, 2020

You mean the link in https://www.ory.sh/kratos/docs/self-service/flows/verify-email-account-activation/#verification-link-method ? "Customizing E-Mail Templates"

(../../concepts/email-sms#templates) seems to be ok, going two levels up you are in /docs and then into /concepts.

I built the docs locally (npm start) and the link points to the correct location. npm build also works.

There is the same problem with the Self-Service link right at the top of the page and all other links (except the on to REST API).
It works fine locally but not deployed.

Is there something happening to the links that i am not aware of?

@vinckr
Copy link
Member

vinckr commented Nov 20, 2020

Seems all links on that page are working again @zepatrik ?

@zepatrik
Copy link
Member Author

Yes. looks so. Can you also fix the links in the versioned docs though? I saw that at least v0.5 is still broken.

@vinckr
Copy link
Member

vinckr commented Nov 20, 2020

at v0.5 all the links are working for me.
/next is also working and in 0.4 its is only some github stuff missing.
Maybe there was some change in the docusaurus that solved it?

@aeneasr
Copy link
Member

aeneasr commented Nov 25, 2020

Can this be closed then?

@vinckr
Copy link
Member

vinckr commented Nov 25, 2020

I just checked again and now all the links are broken again.
I could swear that it worked for me before, no idea...
I see if I can fix it.

@aeneasr
Copy link
Member

aeneasr commented Nov 25, 2020

Yeah strange, the links seem to be correct.

@zepatrik
Copy link
Member Author

It is still broken, and never worked for me.

@zepatrik
Copy link
Member Author

But yes, it looks good in the source...

@vinckr
Copy link
Member

vinckr commented Nov 25, 2020

I checked everything that I can think of, and when I build locally it is working fine.

Maybe some arcane docusaurus magic?

@aeneasr aeneasr self-assigned this Dec 9, 2020
aeneasr added a commit that referenced this issue Dec 9, 2020
@aeneasr aeneasr mentioned this issue Dec 9, 2020
5 tasks
aeneasr added a commit that referenced this issue Dec 9, 2020
aeneasr added a commit that referenced this issue Dec 9, 2020
@aeneasr aeneasr added the corp/m4 Up for M4 at Ory Corp. label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working. corp/m4 Up for M4 at Ory Corp.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants