Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Prometheus monitoring to Public API #1022

Merged
merged 1 commit into from
Jan 31, 2021
Merged

feat: Add Prometheus monitoring to Public API #1022

merged 1 commit into from
Jan 31, 2021

Conversation

mbonnell-wish
Copy link
Contributor

Proposed changes

Currently, the Prometheus metrics middleware is only used on the Admin API. This PR adds it to the Public API, so that Public API requests may be monitored, as well.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@aeneasr aeneasr merged commit 75a4f1a into ory:master Jan 31, 2021
@aeneasr
Copy link
Member

aeneasr commented Jan 31, 2021

Awesome, thank you!

@mbonnell-wish
Copy link
Contributor Author

Thanks for approving! When do you think we'll be able to publish another release? Having this monitoring would be very important for us.

@aeneasr
Copy link
Member

aeneasr commented Feb 2, 2021

This is a bit tricky because we had some breaking changes and are actually waiting for 0.6 to push the next release - which will take some time. In the meanwhile you can use make docker and push it to your own repo!

@mbonnell-wish
Copy link
Contributor Author

This is a bit tricky because we had some breaking changes and are actually waiting for 0.6 to push the next release - which will take some time. In the meanwhile you can use make docker and push it to your own repo!

Sounds good, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants