-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SessionDestroyer test error undefined sid #152
Conversation
Testcase Added for SessionDestroyer
Testcase updated for SessionDestroyer
Testcase added for DeleteSessionFor
Testcase updated for DeleteSessionFor
Fix syntax error for testcases SessionDestroyer & DeleteSessionsFor
Added new post hook in registry_default_hooks
Co-Authored-By: hackerman <3372410+aeneasr@users.noreply.github.com>
Fix SessionDestroyer test error undefined sid
Yuvraj seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Thank you for trying to resolve these issues!. I've pushed up a PR that also includes fixes for these issues! Regarding git workflow, you should never work on one branch. I recommend reading: https://hackernoon.com/high-velocity-software-development-using-nested-git-branches-69bfc2d1e54d There are also other issues in the code, for example a duplicate variable declaration which causes a build failure: https://github.com/ory/kratos/pull/152/files#diff-4c06363fefe733cfec759b8c34d2048fL45 The best way to ensure that your stuff actually works is by running tests, for example using I'm closing this because it superseded by #154 |
Related issue
It will fix the SessionDestroyer test error undefined sid which is created from #139
Proposed changes
Checklist
vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
Further comments