Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration/Login HTML form: remove request field and ensure method is set #183

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

zepatrik
Copy link
Member

Related issue

closes #178

Proposed changes

The request field will not be added any more. The tests make sure it is not present.
We also check from now on that the form method is always set.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

@zepatrik zepatrik requested a review from aeneasr January 22, 2020 11:19
@aeneasr
Copy link
Member

aeneasr commented Jan 22, 2020

Very nice!

@aeneasr aeneasr merged commit e035adc into master Jan 22, 2020
@aeneasr aeneasr deleted the filter-request-field branch January 22, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registration/Login form fields should not include "request"
2 participants