Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(continuity): properly reset cookies that became invalid #2123

Merged
merged 1 commit into from
Jan 8, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jan 8, 2022

Resolves several reports related to incorrect handling of invalid continuity issues.

Closes #2121
Closes ory-corp/cloud#1786
Closes #2016
Potentially #2108

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner January 8, 2022 12:15
@aeneasr aeneasr added the bug Something is not working. label Jan 8, 2022
Resolves several reports related to incorrect handling of invalid continuity issues.

Closes #2121
Closes ory-corp/cloud#1786
Closes #2016
Potentially #2108
@aeneasr aeneasr merged commit 8e4b4fb into master Jan 8, 2022
@aeneasr aeneasr deleted the close-2121-2 branch January 8, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate continuity cookies cause requests to fail Resumable session is not cleared up on error
1 participant