fix: implement offline scope in the way google expects

[tsearle]

google doesn't implements offline access as a scope but instead as a special uri parameter

this PR adapts the code such that if the offline_access scope is requested, it gets transformed into the parameter
access_type=offline

[CLAassistant]

All committers have signed the CLA.

[tsearle]

linked issue
ory/network#242

[codecov]

Codecov Report

Merging #3088 (c997c66) into master (c70704c) will increase coverage by 0.05%.
The diff coverage is 91.30%.

❗ Current head c997c66 differs from pull request most recent head 4c2bb42. Consider uploading reports for the commit 4c2bb42 to get more accurate results

@@            Coverage Diff             @@
##           master    #3088      +/-   ##
==========================================
+ Coverage   77.41%   77.46%   +0.05%     
==========================================
  Files         315      315              
  Lines       19812    19835      +23     
==========================================
+ Hits        15337    15365      +28     
+ Misses       3289     3283       -6     
- Partials     1186     1187       +1     

Impacted Files	Coverage Δ
selfservice/strategy/oidc/provider_google.go	93.33% <91.30%> (+93.33%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[tsearle]

indeed it should be the inverse I'll fix it

…

On Fri, Feb 10, 2023 at 2:14 PM hackerman ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In selfservice/strategy/oidc/provider_google.go <#3088 (comment)>: > + if !stringslice.Has(scope, gooidc.ScopeOfflineAccess) { + options = append(options, oauth2.AccessTypeOffline) + } Not sure if I understand this - if the scope is not "offline_access", we automatically add it? Is that really what we want? — Reply to this email directly, view it on GitHub <#3088 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCUPI4Z4ZA56Z6RD26KVVDWWY5MTANCNFSM6AAAAAAUWUJ7T4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[aeneasr]

Awesome, thank you for your contribution! This looks pretty good and I have some ideas how to improve it further :)

[aeneasr]

Maybe you can add a small test that shows that the offline access thing is correctly configured when the scope is set? :)

[aeneasr]

Thank you for making Ory better :)

[vinckr]

Hello @tsearle
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!