Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use hosted httpbin in e2e tests #3422

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Aug 7, 2023

This should deflake the e2e tests a bit.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #3422 (dc9ddd7) into master (ce8139f) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head dc9ddd7 differs from pull request most recent head 65afa36. Consider uploading reports for the commit 65afa36 to get more accurate results

@@            Coverage Diff             @@
##           master    #3422      +/-   ##
==========================================
- Coverage   78.04%   78.03%   -0.01%     
==========================================
  Files         327      327              
  Lines       21384    21379       -5     
==========================================
- Hits        16689    16684       -5     
  Misses       3457     3457              
  Partials     1238     1238              

see 1 file with indirect coverage changes

@jonas-jonas jonas-jonas marked this pull request as draft August 7, 2023 19:55
@jonas-jonas jonas-jonas marked this pull request as ready for review August 9, 2023 07:25
@aeneasr aeneasr merged commit 3ddff78 into master Aug 9, 2023
26 checks passed
@aeneasr aeneasr deleted the jonas-jonas/useHostedHTTPBin branch August 9, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants