-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hot-reload CORS origins #3423
Conversation
You can start the server and make an HTTP request to an endpoint with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM please verify that empty domains != allow all domains.
Manual testing confirmed it works. |
Tests are failing because of ory/x bump which does not work on mysql thanks to gobuffalo/pop#829 |
Codecov Report
@@ Coverage Diff @@
## master #3423 +/- ##
==========================================
- Coverage 78.02% 78.01% -0.01%
==========================================
Files 327 327
Lines 21402 21406 +4
==========================================
+ Hits 16698 16699 +1
- Misses 3466 3468 +2
- Partials 1238 1239 +1
|
needs ory/x#713
With this PR, CORS allowed-origins will be hot-reloadable. Is there a good place to put an integration test? Only e2e I guess?