-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: claims from userinfo endpoint #3718
Conversation
cfb74ab
to
905b552
Compare
905b552
to
bce741c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3718 +/- ##
==========================================
- Coverage 78.34% 78.33% -0.02%
==========================================
Files 347 347
Lines 23765 23808 +43
==========================================
+ Hits 18619 18650 +31
- Misses 3743 3749 +6
- Partials 1403 1409 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add one test to ensure we don't have SSRF. Otherwise LGTM!
|
Related issue(s)
Fixes https://github.com/ory-corp/cloud/issues/5599
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments