Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: claims from userinfo endpoint #3718

Merged
merged 3 commits into from
Jan 30, 2024
Merged

feat: claims from userinfo endpoint #3718

merged 3 commits into from
Jan 30, 2024

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Jan 29, 2024

Related issue(s)

Fixes https://github.com/ory-corp/cloud/issues/5599

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested review from aeneasr, alnr and piotrmsc January 29, 2024 13:04
@hperl hperl self-assigned this Jan 29, 2024
@hperl hperl force-pushed the hperl/generic-userinfo branch 2 times, most recently from cfb74ab to 905b552 Compare January 30, 2024 07:27
@hperl hperl force-pushed the hperl/generic-userinfo branch from 905b552 to bce741c Compare January 30, 2024 07:28
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (549308d) 78.34% compared to head (c1c809f) 78.33%.

Files Patch % Lines
selfservice/strategy/oidc/provider_generic_oidc.go 79.16% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3718      +/-   ##
==========================================
- Coverage   78.34%   78.33%   -0.02%     
==========================================
  Files         347      347              
  Lines       23765    23808      +43     
==========================================
+ Hits        18619    18650      +31     
- Misses       3743     3749       +6     
- Partials     1403     1409       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alnr alnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add one test to ensure we don't have SSRF. Otherwise LGTM!

@hperl
Copy link
Contributor Author

hperl commented Jan 30, 2024

Please add one test to ensure we don't have SSRF. Otherwise LGTM!

Test is here: https://github.com/ory/kratos/pull/3718/files#diff-34afe837dee17ff4a5ed4b81037a684d93d6ee3d067cbbdd9b8e176f812af6aaR60

@hperl hperl merged commit 90bdc61 into master Jan 30, 2024
29 checks passed
@hperl hperl deleted the hperl/generic-userinfo branch January 30, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants