Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move b2b config to selfservice section #3949

Merged
merged 3 commits into from
Jun 11, 2024
Merged

chore: move b2b config to selfservice section #3949

merged 3 commits into from
Jun 11, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jun 11, 2024

Related issue(s)

Organizing this key to be located where all the other login methods are as well which helps with consistency when automating orgs.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@@ -1420,6 +1593,48 @@
"type": "object",
"additionalProperties": false,
"properties": {
"b2b": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant section

"type": "boolean",
"title": "Enable faster session extension",
"description": "If enabled allows faster session extension by skipping the session lookup. Disabling this feature will be deprecated in the future.",
"default": false
}
},
"additionalProperties": false
},
"organizations": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will remove this once it's on prod

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.18%. Comparing base (4e3fad4) to head (de6336b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3949      +/-   ##
==========================================
+ Coverage   78.17%   78.18%   +0.01%     
==========================================
  Files         362      362              
  Lines       25433    25433              
==========================================
+ Hits        19881    19885       +4     
+ Misses       4030     4028       -2     
+ Partials     1522     1520       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 1bc4dc5 into master Jun 11, 2024
20 of 22 checks passed
@aeneasr aeneasr deleted the add-org-key branch June 11, 2024 11:12
fenech pushed a commit to nbycomp/kratos that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants