Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-add WithIdentifier #3992

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.34%. Comparing base (e070b27) to head (dbc6da4).

Additional details and impacted files
@@                Coverage Diff                 @@
##           two-step-login    #3992      +/-   ##
==================================================
- Coverage           78.35%   78.34%   -0.01%     
==================================================
  Files                 369      369              
  Lines               25975    25979       +4     
==================================================
+ Hits                20352    20353       +1     
- Misses               4075     4078       +3     
  Partials             1548     1548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas merged commit 0da0c9b into two-step-login Jul 10, 2024
25 of 26 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/reintroduceWithIdentifier branch July 10, 2024 10:49
aeneasr pushed a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants