Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter web hook headers #4048

Merged
merged 2 commits into from
Aug 23, 2024
Merged

fix: filter web hook headers #4048

merged 2 commits into from
Aug 23, 2024

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Aug 21, 2024

This enforces an allow list for the request headers sent to a web hook target.

Related issue(s)

Related to https://github.com/ory-corp/cloud/issues/6181

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from piotrmsc August 21, 2024 13:00
@hperl hperl self-assigned this Aug 21, 2024
@hperl hperl requested review from aeneasr and zepatrik as code owners August 21, 2024 13:00
@hperl hperl force-pushed the hperl/whitelist-web-hook-data branch from bc740fc to 12e2844 Compare August 22, 2024 06:18
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (68693a4) to head (12e2844).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4048       +/-   ##
===========================================
+ Coverage        0   78.35%   +78.35%     
===========================================
  Files           0      370      +370     
  Lines           0    26125    +26125     
===========================================
+ Hits            0    20470    +20470     
- Misses          0     4094     +4094     
- Partials        0     1561     +1561     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hperl hperl requested a review from alnr August 22, 2024 08:43
@aeneasr aeneasr merged commit ddb838e into master Aug 23, 2024
27 checks passed
@aeneasr aeneasr deleted the hperl/whitelist-web-hook-data branch August 23, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants