Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve tracing for all selfservice strategies #4061

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

zepatrik
Copy link
Member

Most of the self-service strategies were not adding traces.

@aeneasr
Copy link
Member

aeneasr commented Aug 27, 2024

I've done this in another PR, please hold off merging

@aeneasr
Copy link
Member

aeneasr commented Aug 28, 2024

Ok, my changes are on master now. I'm not sure, maybe I missed some pieces.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 61.22449% with 76 lines in your changes missing coverage. Please review.

Project coverage is 78.50%. Comparing base (f7c1024) to head (3daeaa1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
selfservice/strategy/oidc/strategy_registration.go 55.31% 19 Missing and 2 partials ⚠️
selfservice/strategy/oidc/strategy.go 59.45% 13 Missing and 2 partials ⚠️
selfservice/strategy/oidc/strategy_login.go 37.50% 13 Missing and 2 partials ⚠️
...fservice/strategy/profile/two_step_registration.go 40.00% 6 Missing ⚠️
selfservice/strategy/passkey/passkey_login.go 63.63% 1 Missing and 3 partials ⚠️
selfservice/strategy/passkey/passkey_settings.go 60.00% 3 Missing and 1 partial ⚠️
selfservice/strategy/code/strategy_login.go 33.33% 2 Missing ⚠️
selfservice/strategy/oidc/strategy_settings.go 77.77% 2 Missing ⚠️
selfservice/strategy/profile/strategy.go 50.00% 0 Missing and 2 partials ⚠️
selfservice/strategy/webauthn/login.go 50.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4061      +/-   ##
==========================================
+ Coverage   78.46%   78.50%   +0.03%     
==========================================
  Files         376      376              
  Lines       26728    26755      +27     
==========================================
+ Hits        20973    21003      +30     
  Misses       4151     4151              
+ Partials     1604     1601       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zepatrik zepatrik changed the title chore: add tracing for all selfservice strategies chore: improve tracing for all selfservice strategies Sep 13, 2024
@zepatrik zepatrik merged commit 5830ffb into master Sep 13, 2024
29 of 30 checks passed
@zepatrik zepatrik deleted the chore/strategy-tracing branch September 13, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants