Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change primary key on identity_verifiable_addresses and identity_recovery_addresses #4139

Closed
wants to merge 2 commits into from

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 2, 2024

Moves to SQL migrations

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.60%. Comparing base (ad1acd5) to head (6220240).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
driver/registry.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4139      +/-   ##
==========================================
- Coverage   78.60%   78.60%   -0.01%     
==========================================
  Files         377      377              
  Lines       26914    26920       +6     
==========================================
+ Hits        21156    21160       +4     
- Misses       4148     4150       +2     
  Partials     1610     1610              
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,3 @@
ALTER TABLE identity_verifiable_addresses
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does mysql not have a unique index for the id?

@aeneasr aeneasr closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants